Wireshark-bugs: [Wireshark-bugs] [Bug 3069] g_array_append_val should not acdept pointer as argu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 20 Nov 2008 00:20:25 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3069





--- Comment #3 from LEGO <luis.ontanon@xxxxxxxxx>  2008-11-20 00:20:23 PDT ---
(In reply to comment #2)
> This code was added in revision 21686. The commit comment stated this new
> functionality wasn't tested yet.
> Luis, this patch and comment makes sense. Was there no further testing/use of
> this function?
> 

I added that function for completeness when I added the wtap modules. I never
got it tested because I did not have any files to be decoded with yet-unknown
encapsulations. The wtap-modules I wrote and couldn't commit (an internal trace
format whose description is in non-public docs) had had known MTP2/MTP3 encaps.

The patch is correct, that is a sound bug ( in fact  two bugs, it fixes a leak
as well).


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.