Wireshark-bugs: [Wireshark-bugs] [Bug 3058] New: the comment for dissect_nt_sid is not correct
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 13 Nov 2008 20:29:50 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3058

           Summary: the comment for dissect_nt_sid is not correct
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: yamisoe@xxxxxxxxx



yami <yamisoe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2485|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2485)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2485)
correct the comment and move it to the header file

Build Information:
Version 1.1.2 (SVN Rev 26775)

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.9, with GLib 2.16.3, with libpcap 0.9.8, with libz
1.2.3.3, with POSIX capabilities (Linux), with libpcre 7.4, without SMI,
without
c-ares, with ADNS, without Lua, with GnuTLS 2.0.4, with Gcrypt 1.2.4, with MIT
Kerberos, without GeoIP, with PortAudio <= V18, without AirPcap.

Running on Linux 2.6.24-16-generic, with libpcap version 0.9.8.

Built using gcc 4.2.3 (Ubuntu 4.2.3-2ubuntu7).

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
The comment for epan/dissectors/packet-windows-common.c:dissect_nt_sid is not
right. The sid_str should not be freed by the caller.

The patch uploaded fixes this, and move the comment to the header file, since
dissect_nt_sid is public visible.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.