Wireshark-bugs: [Wireshark-bugs] [Bug 3025] New: ASN.1: display the real name of SEQUENCE/TYPE O
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 31 Oct 2008 02:19:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3025

           Summary: ASN.1: display the real name of SEQUENCE/TYPE OF
                    parameters
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: pascal.quantin@xxxxxxxxx



Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2436|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=2436)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=2436)
asn2rws.py patch to display SEQUENCE/TYPE OF field name

Build Information:
Version 1.1.2

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.14.3, with GLib 2.18.1, with WinPcap (version unknown),
with libz 1.2.3, without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8,
with c-ares 1.5.3, with Lua 5.1, with GnuTLS 2.3.8, with Gcrypt 1.4.1, with MIT
Kerberos, without GeoIP, with PortAudio V19-devel (built Oct 30 2008), with
AirPcap.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, without
AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
With the current version of asn2wrs.py, when we encounter a SEQUENCE OF or a
SET OF parameter in ASN.1 description, this will to this generated code:

    { &hf_rrc_DynamicPersistenceLevelList_item,
      { "Item", "rrc.DynamicPersistenceLevelList_item",
        FT_UINT32, BASE_DEC, NULL, 0,
        "rrc.DynamicPersistenceLevel", HFILL }},

All those type of parameters are displayed as "Item" when performing the
dissection.
This lead to this kind of meaningless decoding:

SysInfoType7
    modeSpecificInfo: fdd (0)
        fdd
            ul-Interference: -100
    prach-Information-SIB5-List: 1 item
        Item 0
            Item: 2
    prach-Information-SIB6-List: 1 item
        Item 0
            Item: 2

With the attached patch, the code generated looks like this:

    { &hf_rrc_DynamicPersistenceLevelList_item,
      { "DynamicPersistenceLevelList", "rrc.DynamicPersistenceLevelList_item",
        FT_UINT32, BASE_DEC, NULL, 0,
        "rrc.DynamicPersistenceLevel", HFILL }},

And the decoding is much nicer:

SysInfoType7
    modeSpecificInfo: fdd (0)
        fdd
            ul-Interference: -100
    prach-Information-SIB5-List: 1 item
        Item 0
            DynamicPersistenceLevelList: 2
    prach-Information-SIB6-List: 1 item
        Item 0
            DynamicPersistenceLevelList: 2


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.