Wireshark-bugs: [Wireshark-bugs] [Bug 3013] Simplfy/generalize proto_tree_add_bits_ret_val()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 30 Oct 2008 00:35:47 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3013





--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-10-30 00:35:47 PDT ---
Well, there's even more to it than that.


Why are 'bit_offset' and 'no_of_bits' signed values? What happens when negative
values are passed here? Usually that is to signal values from the *end* of the
TVB, but I don't see that happening. 

"}else if(no_of_bits>64){" is a bogus conditional, it should be dropped.

"       if(hf_index == -1)
                return NULL;" is bogus since the first line of the function
would have asserted if this was true.

"       if(return_value){
                *return_value=value;
        }" should be done right after the gathering of the value, it looks out
of place there.

"                       const true_false_string         *tfstring =
&tfs_true_false;" is a bogus initializer, since you already know it's going to
be replaced by a TFS.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.