Wireshark-bugs: [Wireshark-bugs] [Bug 2971] Add new Bssap dissectors for the Lb interface
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2971
--- Comment #11 from Johnny Mitrevski <mitrevj@xxxxxxxxxxx> 2008-10-22 17:55:29 PDT ---
Hello Anders,
In answer to your question about the differences between BSSMAP over the Lb and
GSM-A interface.
If you compare the Lb interface (3GPP TS 49.031 V7.4.0) with the GSM-A (3GPP TS
48.008) you will notice that there are additional IEs on the Lb interface that
only an SGSN will need to send. For example, a Perform Location Request on the
Lb interface has extra LCS Capability, Packet Measurement Report, and Measured
Cell Identity List IE's.
As for the encoding of the IE's themselves. I agree that there is commonality
on the encode/decode of the IE's. However, we noticed that in the existing
decode of the BSSMAP IEs that only a very small number had been decoded, most
come up as "Not Decoded Yet", prompting the need to implement the dissectors.
Do you have any plans to add the additional BSSMAP dissectors to your
implementation?
If not, I'd suggest the following approach to the BSSMAP work:
1) Move IE's that are common between BSSMAP and BSSMAP_LE from
packet-lb_bssmap_le.c into the packet-gsm_a_common.x
2) Refactor packet-lb_bssmap_le.c to now use dissectors from
packet-gsm_a_common.x. This should sit within your existing framework.
3) Leave BSSMAP_LE specific IE's, such as LCS Capability IE, in
packet-lb_bssmap_le.c
4) I still believe that there is sufficient reason to separate the GSM-A and Lb
interface. So I believe that renaming the bssmap_le file to
packet-gsm_a_bssmap_le.c would be misleading. Perhaps calling the file
packet-gsm_bssmap_le.c would be more appropriate? If this is the case, then
changing packet-gsm_a_bsslap.c to packet-gsm_bsslap.c (drop the a) would be
more appropriate as well.
5) The preference selector for GSM-A and Lb interface in
Edit->Preferences->BSSAP would also need to remain to select either bssmap or
bssmap_le.
Any thoughts?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
