Wireshark-bugs: [Wireshark-bugs] [Bug 2935] New simulcrypt protocol dissector
Date: Thu, 9 Oct 2008 08:51:50 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2935





--- Comment #13 from David Castleford <david.castleford@xxxxxxxxxxxxxxxxxx>  2008-10-09 08:51:50 PDT ---
(In reply to comment #10)
> Re: building param_value
> 
> After poking around a bit I found that the following can be used:
> 
>    gchar *param_value;
>    ...
>    param_value = tvb_bytes_to_str_punct(tvb, offset, plen, ' ');
>    offset += plen;
>    ....
> 
>    (The ptr returned by tvb_bytes_to_str_punct points to a temporary buffer
>     whose space is freed before the next frame is dissected).
> 
> The result is similar to that from the current code except that the string
> created will only show the first 16 bytes (with a ... if plen > 16 bytes).
> 
> This actually seems a bit nicer since to me since parameters with long values
> (eg: ECM_DATAGRAM) won't run off the right side of the window. However, YMMV.
> 
used tvb_bytes_to_str as was busy on your initial remarks, feel free to add
_punct
(had uploaded patch before re-reading your comment.... ;-) )
I'd be happy with an extra space between bytes too


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.