Wireshark-bugs: [Wireshark-bugs] [Bug 2907] New: conversation_new without preceding find_convers
Date: Sun, 28 Sep 2008 18:07:55 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2907

           Summary: conversation_new without preceding find_conversation
           Product: Wireshark
           Version: SVN
          Platform: All
               URL: http://www.wireshark.org/lists/wireshark-
                    dev/200809/msg00072.html
        OS/Version: Windows XP
            Status: NEW
          Severity: Normal
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: christopher.maynard@xxxxxxxxx


Build Information:
SVN 26286
--
I have found 3 dissectors that call conversation_new() without a preceding call
to find_conversation():

1) packet-bittorrent.c
2) packet-dtpt.c
3) packet-quake.c

I don't believe this should ever be allowed, and I would concur with didier in
his follow-up post
(http://www.wireshark.org/lists/wireshark-dev/200809/msg00075.html) that
refactoring these functions is a wise idea.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.