Wireshark-bugs: [Wireshark-bugs] [Bug 2831] Add support the KDP (Kontiki Delivery Protocol)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 27 Aug 2008 14:49:41 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2831





--- Comment #2 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-08-27 14:49:40 PDT ---
Hi, 

A few quick remarks on the code:

1. The copyright statement is not really how we like it. Have a look at
packet-acn.c for a proper example.
2. Don't include stuff you don't use, like prefs.h
3. Define you macro's within parenthesis, like: #define KDP_DROP_FLAG (1<<0)
4. Never manipulate column within a 'if (tree)' conditional. This breaks column
update on uncoloured/unfilted captures.
5. body_len should be based on tvb_length_remaining(). The captured frames
could be snipped, hence the reported data is not actually there.
6. sprintf() is depricated, replace by g_snprintf()
7. printf() is not the way to log errors. If you must, use the expert info
system.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.