Wireshark-bugs: [Wireshark-bugs] [Bug 2822] Unusual use of a Boolean (Lint warning 514)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 21 Aug 2008 15:35:30 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2822


LEGO <luis.ontanon@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis.ontanon@xxxxxxxxx
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from LEGO <luis.ontanon@xxxxxxxxx>  2008-08-21 15:35:28 PDT ---
Those are clearly true positives.

The coding_standard one could have been noticed and reported.

But the hash one, no way someone would had ever sensed it!

That hashing can yield only 3 values (0,1,2) degenerating lookups into 1/3 of a
sequential search (very bad for something that uses 64bit ids!). It works, much
slower. If tested on a small set it just doesn't appear. This one could had
been hidden there for centuries!


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.