Wireshark-bugs: [Wireshark-bugs] [Bug 2741] Improve robustness of proto_tree_free
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 20 Aug 2008 12:06:25 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2741





--- Comment #1 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-08-20 12:06:22 PDT ---
This is essentially a two part patch.
1. Simplification of proto_tree_traverse_in_order() 
2. Rigging of proto_tree_free_node() to ensure object relation validity

The first item looks oke to me, removing entropy is a good thing.

The second item is indeed an improvement in the sense that it makes sure the
object relations remain valid. On the other hand, the actual application of the
functionality is only for the destruction of complete trees, never for
individual nodes nor subtrees. Hence this only adds to the processing without
adding functionality. Therefore it can be left out IMHO.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.