Wireshark-bugs: [Wireshark-bugs] [Bug 2752] Add Ethernet Global Data dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 1 Aug 2008 03:03:52 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2752





--- Comment #9 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-08-01 03:03:49 PDT ---
You forgot to address the first point. It was a quiz question. ;)
The answer is you forgot to put in the line 'initialized = TRUE;' in
proto_reg_handoff_egd()

About the data print, I understand the add_byte_array_text_to_proto_tree() in
packet-cip.c and packet-enip.c. They were added when there was no other way to
display raw data in the packet details pane. 
That was exactly the reason why I added a data field to the data dissector
which presents the raw data as an hex array, just like
add_byte_array_text_to_proto_tree(). So I intend to have a good look and maybe
rip these out of packet-cip.c and packet-enip.c. Or replace them with a
FT_BYTES field, because that does the same thing basically.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.