Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2761] New: Fix proto_tree_add_*_format_value() operation on bitfields

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2761

           Summary: Fix proto_tree_add_*_format_value() operation on
                    bitfields
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: avn@xxxxxxxxxxxxxxx


Build Information:
wireshark 1.0.99 (SVN Rev 25886)

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.9, with GLib 2.16.3, with libpcap 0.9.8, with libz
1.2.3.3, without POSIX capabilities, without libpcre, without SMI, without
ADNS,
without Lua, without GnuTLS, without Gcrypt, without Kerberos, without
PortAudio, without AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.24-19-generic, with libpcap version 0.9.8.

Built using gcc 4.2.3 (Ubuntu 4.2.3-2ubuntu7).
--
According to documentation, "the name of the field is added automatically as in
the proto_tree_add_XXX() functions". However, there was a difference: the
*_format_value functions did not print the bitmask representation (those dots
and zeros and ones) when it operated on a field with non-zero bitmask. This
patch fixes such deviation from the documentation.

The only use of the "old" behavior was in packet-bvlc.c. There, the bitmask is
not needed, since it prints a 16-bit value (FT_UINT16) with a bitmask of
0xffff.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.