Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2748] M3UA dissector should mark "MTP3 equivalents" as generated.

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2748





--- Comment #2 from Abhik Sarkar <sarkar.abhik@xxxxxxxxx>  2008-07-29 03:26:30 PDT ---
True. But, I found it a bit confusing as a user since "MTP3 equivalents" isn't
really one of the protocol parameters/fields. What I was going to suggest is
this:

Index: epan/dissectors/packet-m3ua.c

===================================================================

--- epan/dissectors/packet-m3ua.c       (revision 25800)

+++ epan/dissectors/packet-m3ua.c       (working copy)

@@ -1147,6 +1147,7 @@

     proto_item_set_len(parameter_item, PARAMETER_HEADER_LENGTH +
DATA_HDR_LENGTH);

     item = proto_tree_add_text(parameter_tree,parameter_tvb,0,0,"MTP3
equivalents");
+    PROTO_ITEM_SET_GENERATED(item);
     parameter_tree = proto_item_add_subtree(item,ett_mtp3_equiv);

     proto_tree_add_item(parameter_tree, hf_protocol_data_mtp3_opc,
parameter_tvb, DATA_OPC_OFFSET, DATA_OPC_LENGTH, NETWORK_BYTE_ORDER);

That is, only mark the section as generated, but continue to show the data as
being present in the actual packet.

I leave it to you... if you decide against it, you can close the bug.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.