https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2707
--- Comment #3 from Abhik Sarkar <sarkar.abhik@xxxxxxxxx> 2008-07-22 05:55:40 PDT ---
(In reply to comment #1)
> Checked in rev 25787 with a couple changes:
Thanks for checking in this enhancement, Jeff!
>
> 1) There are a bunch of (new) value_strings and range_strings that were not
> NULL terminated. This could cause a crash.
Noted... I read about this subsequently while I was working on the next
enhancement.
>
> 2) Don't call VALS() on range_strings--they need RVALS(). (That produced a
> compile warning/error on Linux.)
Noted.
>
>
> If you're going to submit more patches against this I see a few other things
> that could use improving in here:
>
> - the comment at the top of the file still says SMPP 3.4
Already fixed in the upcoming patch.
> - there are many hard coded values in the code like:
>
> + case 0x0605: /* broadcast_frequency_interval */
>
> I would prefer those to be #defines (which would then allow us to lose the
> comments).
Will do.
> And should those tags be added to the tree? If they were then the
> #defines could also be used in a value string for pretty-printing.
I don't quite understand how. Can you point me to an example? Thanks.
>
> Of course any updates to the SMPP Wiki page would also be welcome.
Yup... I will get on this shortly.
>
> Thanks for your contribution!
The pleasure is all mine (especially with the support I have been getting from
the core developers :-)
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
