Wireshark-bugs: [Wireshark-bugs] [Bug 2692] ged125 dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 17 Jul 2008 08:58:27 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2692





--- Comment #3 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-07-17 08:58:26 PDT ---
Looked at the code quickly, still got some questions:
1. Why no switch statement used, just endless repeats of 'if (...)'?
2. Could you clean up old comments?
3. Comments refer to a document, but I can't find a reference to it.
4. Is this tooltip for the "desegment_body" preference valid?
5. Indentation varies in quality.
6. Why yell SIZE in function parameters? All caps are for constants.
7. Some non-ASCII chars in there, not all compiler like that.
8. How do we / you fuzztest this code? Sample capture maybe?


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.