Wireshark-bugs: [Wireshark-bugs] [Bug 2681] glithes in current ssl decrypt code
Date: Tue, 8 Jul 2008 00:40:04 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2681





--- Comment #7 from Paolo Abeni <paolo.abeni@xxxxxxxx>  2008-07-08 00:40:03 PDT ---
(In reply to comment #6)
> The comment in the code states:
> <quote>
> /* look in openssl/ssl/ssl_lib.c for a complete list of available cipersuite */
> </quote>
> I looked, but that is not the place where you got it from, I presume. What
> would be a better reference to put into this comment?

The relevant RFCs and other resources are listed in previous comments into the
code (packet-ssl-utils.c, in the ssl_20_cipher_suites and ssl_31_ciphersuite
arrays definition) . These are all the relevant RFCs:

 * RFC 2246 appendix C
 * RFC 4346 appendix C
 * RFC 2712 section 3
 * RFC 4785 section 3
 * RFC 3268
 * RFC 4132 sections 2-3
 * RFC 4279 section 6
 * RFC 4162 sections 2-3.1
 * RFC 4492 section 6

If you like, I can post another version of the patch with said references
replacing the comment you reported. Please note that said references are yet
present into the code, so probably it would be better just drop the misleading
comment


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.