Wireshark-bugs: [Wireshark-bugs] [Bug 2688] Mojito Protocol Dissestor Plugin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 7 Jul 2008 07:24:23 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2688





--- Comment #1 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-07-07 07:24:20 PDT ---
Please review the README.developer section 1.6 on 'display'.
This involves the 'FT_BOOLEAN, BASE_DEC' and 'FT_IPv4, BASE_DEC,' specs in your
code. 
Did you, or can you provide sample captures for, fuzz tests?
Changing the port will not move the registration from the old to the new udp
port. Please review other dissectors (like packet-actrace.c) how to achieve
that.
Do not fill the info column, or any other column for that matter, under the
condition of (tree!=NULL). This is condition is true when there are no display
filters are in effect and the packet overview is assembled.
Please define constants to make explicit mapping between this:
        { 7, "FIND VALUE REQUEST" },
and this
        case 7: /* FIND VALUE REQUEST */
, like so:
#define FIND_VALUE_REQUEST 7


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.