Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2650] New: Improper code handling..

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2650

           Summary: Improper code handling..
           Product: Wireshark
           Version: 1.0.0
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Trivial
          Priority: High
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: arun2.b@xxxxxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
Hi, 
I was doing a code walk through in reassemble.c file and found a "Mysterious"
piece of code in fragment_add_seq_key() function..
I have copied that code below.. Why is the code written so?? What is the
correction recommeneded??

/*
                 * If we weren't given an initial fragment number,
                 * make it 0.
                 */
                if (flags & REASSEMBLE_FLAGS_NO_FRAG_NUMBER)
                        frag_number = 0;
        } else {
                if (flags & REASSEMBLE_FLAGS_NO_FRAG_NUMBER) {
                        fragment_data *fd;
                        /*
                         * If we weren't given an initial fragment number,
                         * use the next expected fragment number as the
fragment
                         * number for this fragment.
                         */
                        for (fd = fd_head; fd != NULL; fd = fd->next) {
                                if (fd->next == NULL)
                                        frag_number = fd->offset + 1;
                        }
                }


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.