Wireshark-bugs: [Wireshark-bugs] [Bug 2644] Request addition of FIP dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 26 Jun 2008 13:45:18 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2644


Joe Eykholt <joe@xxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1915 is|0                           |1
           obsolete|                            |




--- Comment #2 from Joe Eykholt <joe@xxxxxxxxxxxxxxxx>  2008-06-26 13:45:17 PDT ---
Created an attachment (id=1920)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=1920)
rev 2 of patch to add FIP dissector

Hi Jaap,  Thanks for reviewing the FIP dissector.

COL_INFO is an enum value, so I'm confused.  Here COL means column, 
not color.

I looked at the source for check_col, and if cinfo is NULL it just returns
FALSE, so there's no harm in the way it is.

The IPv4 dissector dissect_ip() also uses check_col() before testing tree.

> > The dissector will break (with a BoundsError?) when dlen==0. Either that or
> > loop indefinitely.

Good catch.  I've updated the patch to handle that more nicely.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.