Wireshark-bugs: [Wireshark-bugs] [Bug 2646] Rework RTMPT dissector to correctly deal with chunke
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 26 Jun 2008 12:01:56 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2646


Gerald Combs <gerald@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gerald@xxxxxxxxxxxxx




--- Comment #1 from Gerald Combs <gerald@xxxxxxxxxxxxx>  2008-06-26 12:01:55 PDT ---
When I apply you patch, gcc fails with

packet-rtmpt.c: In function 'dissect_rtmpt_tcp':
packet-rtmpt.c:451: warning: 'cmd' may be used uninitialized in this function

It looks like cmd isn't initialized until line 626.

GLib provides GINT_TO_POINTER and GPOINTER_TO_INT. You shouldn't have to roll
your own with int_2_ptr and ptr_2_int.

Have you fuzzed your changes? http://wiki.wireshark.org/FuzzTesting

BTW, the g_alloc crash was due to a problem in tvbuff.c, which was fixed in
25498.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.