Wireshark-bugs: [Wireshark-bugs] [Bug 2548] wimax UL-MAP ext IE decode error
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 21 Jun 2008 01:45:55 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2548





--- Comment #5 from Frank Wang <frank.wang@xxxxxxxxxxx>  2008-06-21 01:45:50 PDT ---
pletohs defined as this.

#define pletohs(p) ((guint16)                       \
                    ((guint16)*((const guint8 *)(p)+1)<<8|  \
                     (guint16)*((const guint8 *)(p)+0)<<0))

so when the value in (p) is already network byte order (as in ULMAP), the MACRO
will get a wrong value no matter whether the machine is LE or BE.

so we should use pntohs.


we should use the label "CQICH_Alloc_IE" in line 1158 of msg_ulmap.c. 

The function name do not need to be changed because it is already 
gint CQICH_Alloc_IE(proto_tree *uiuc_tree, const guint8 *bufptr, gint offset,
gint length, tvbuff_t *tvb)


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.