Wireshark-bugs: [Wireshark-bugs] [Bug 2091] X25 reassembly when presenting out of order packets
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2091
Gerhard Olsson <gerhard.nospam@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1739|review_for_checkin? |
Flag| |
Attachment #1739 is|0 |1
obsolete| |
Attachment #1752| |review_for_checkin?
Flag| |
--- Comment #7 from Gerhard Olsson <gerhard.nospam@xxxxxxxxx> 2008-04-29 06:16:43 GMT ---
Created an attachment (id=1752)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1752)
Updated patch, avoid "XOT reassembly failure" (diff to svn)
The first patch (and the update) will in some situations trigger "XOT
reassembly error" due to the fixed length is variable. Some packets may have
been handled incorrectly as well (the error message was sufficient reason to
rework the patch).
In addition, the patch is now independent of 2103.
2103 still makes sense for other operators, but not required here.
The reason is that since the "XOT sequence" do not have a fixed length to check
the size, as it may require many packets, the number of bytes requested when
the fixed_len is fine but total len is not should always be:
pinfo->desegment_len = DESEGMENT_ONE_MORE_SEGMENT;
Since that change probably should not be put in packet-tcp.c the handling
should be in XOT anyway.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
