Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2263] new wireshark dissector for SERCOS III (ethertype 0x88cd)

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2263


Hans-Peter Bock <xbk@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1592|review_for_checkin?         |
               Flag|                            |
Attachment #1592 is|0                           |1
           obsolete|                            |
   Attachment #1693|                            |review_for_checkin?
               Flag|                            |




--- Comment #11 from Hans-Peter Bock <xbk@xxxxxxxxxx>  2008-04-15 00:31:19 GMT ---
Created an attachment (id=1693)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1693)
new patch for review

> packet-sercosiii*.c missing GPL statement and $Id$ line.
> packet-sercosiii*.c has moduleinfo.h, which it doesn't need.
> "proto_tree* errortree _U_ = NULL;" what does this do?
> We've got no clue what 1009 means. A #define would make it so much more
readable
> You use malloc and free for some purpose. We prefer using se_ or ep_ functions
for that. Please refer to README.malloc in doc/

fixed

I also created AUTHORS and COPZING.

Additionally Makefiles in epan and packaging/nsis have been adapted with regard
to README.plugins

$ svn status -q
M      configure.in
M      Makefile.am
M      Makefile.nmake
A      plugins/sercos
A      plugins/sercos/packet-sercosiii_1v1_svc.c
A      plugins/sercos/packet-sercosiii_1v1_conn.c
A      plugins/sercos/packet-sercosiii_1v1_at_devstat.c
A      plugins/sercos/packet-sercosiii.h
A      plugins/sercos/AUTHORS
A      plugins/sercos/moduleinfo.h
A      plugins/sercos/packet-sercosiii_1v1_mst.c
A      plugins/sercos/packet-sercosiii_1v1_at.c
A      plugins/sercos/moduleinfo.nmake
A      plugins/sercos/packet-sercosiii_1v1_mdt_devctrl.c
A      plugins/sercos/packet-sercosiii_1v1_hp.c
A      plugins/sercos/Makefile.common
A      plugins/sercos/packet-sercosiii_1v1.c
A      plugins/sercos/plugin.rc.in
A      plugins/sercos/Makefile.nmake
A      plugins/sercos/COPYING
A      plugins/sercos/Makefile.am
A      plugins/sercos/packet-sercosiii_1v1_mdt.c
M      plugins/Makefile.nmake
M      plugins/Makefile.am
M      epan/Makefile.am
M      packaging/nsis/Makefile.nmake
M      packaging/nsis/wireshark.nsi


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.