Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2457] New: patch to fix wireshark-filter man page for packet-diameter_3gpp.c f

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2457

           Summary: patch to fix wireshark-filter man page for packet-
                    diameter_3gpp.c fields
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: jyoung@xxxxxxx


Build Information:
Version 1.0.99 (SVN Rev 24887)

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.8.3, with GLib 2.8.1, with libpcap 0.9.2, with libz 1.2.3,
with POSIX capabilities (Linux), without libpcre, without SMI, without ADNS,
without Lua, with GnuTLS 1.2.5, with Gcrypt 1.2.1, without Kerberos, with
PortAudio V19-devel, without AirPcap.
NOTE: this build doesn't support the "matches" operator for Wireshark filter
syntax.

Running on Linux 2.6.13-15.18-default, with libpcap version 0.9.2.

Built using gcc 4.0.2 20050901 (prerelease) (SUSE Linux).

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
Hello,

Within the packet-diameter_3gpp.c module, the call to proto_register_protocol()
comes AFTER the proto_register_field_array() call.   This appears to be
contrary to other packet-*.c modules where the call the
proto_register_protocol() preceeds the call to register the display filters (if
any).

The packet-diameter_3gpp.c module currently defines four fields (display
filters)...

     diameter.3gpp.ipaddr
     diameter.3gpp.mbms_required_qos_prio
     diameter.3gpp.tmgi
     diameter.3gpp.mbms_service_id

While the delayed call to proto_register_protocol() does not appear to impair
the use of the display filters, it DOES effect the generation of the
wireshark-filter man page.

Currently the wireshark-filter man page documents four odd named protocols, one
for each of the diameter_3gpp's display filters...

<snip>
> Allocation/Retention Priority (diameter.3gpp.mbms_required_qos_prio)
<snip>
> IPv4 Address (diameter.3gpp.ipaddr)
<snip>
> MBMS Service ID (diameter.3gpp.mbms_service_id)
<snip>
> TMGI (diameter.3gpp.tmgi)
<snip>

With the attached trivial patch applied the generated man page is properly
constructed....

<snip>
> Diameter 3GPP (diameter3gpp)
>
>     diameter.3gpp.ipaddr  IPv4 Address
>         IPv4 address
>         IPv4 Address
>
>     diameter.3gpp.mbms_required_qos_prio  Allocation/Retention Priority
>         Unsigned 8-bit integer
>         Allocation/Retention Priority
>
>     diameter.3gpp.mbms_service_id  MBMS Service ID
>         Unsigned 24-bit integer
>         MBMS Service ID
>
>     diameter.3gpp.tmgi  TMGI
>         Byte array
>         TMGI
>
<snip>


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.