Wireshark-bugs: [Wireshark-bugs] [Bug 2439] New: patch for tvb_get_bits16 not to read past end o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 9 Apr 2008 21:31:21 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2439

           Summary: patch for tvb_get_bits16 not to read past end of buffer
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: mccart@xxxxxxxxxxxxxxxxxx



Michael McCartney <mccart@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1654|                            |review_for_checkin?
               Flag|                            |


Created an attachment (id=1654)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1654)
epan/tvbuff.c svn diff patch

Build Information:
wireshark -v
wireshark 1.0.99

Copyright 1998-2008 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.0, with GLib 2.14.1, with libpcap 0.9.7, with libz
1.2.3.3, without POSIX capabilities, with libpcre 7.4, without SMI, with ADNS,
without Lua, with GnuTLS 1.6.3, with Gcrypt 1.2.4, without Kerberos, without
PortAudio, without AirPcap.

Running on Linux 2.6.22-14-generic, with libpcap version 0.9.7.

Built using gcc 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2).

--
When using proto_tree_add_bits_item() on the last 11 bits 
of the last 2 bytes in tvb, malformed packet error occurs
because tvb_get_bits16() tries to read past end of buffer.
This patch fixes tvb_get_bits16() using similiar fix in 
tvb_get_bits8().  Tested and works.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.