Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2433] add parsing of port ranges in ./wireshark/services

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2433


Andrew Feren <acferen@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1652 is|0                           |1
           obsolete|                            |
   Attachment #1653|                            |review_for_checkin?
               Flag|                            |




--- Comment #5 from Andrew Feren <acferen@xxxxxxxxx>  2008-04-09 19:20:24 GMT ---
Created an attachment (id=1653)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1653)
address more comments from Guy

Adds MAX_DCCP_PORT to range.h
bails if the protocol isn't tcp,udp,sctp, or dccp.

As for the static vars.  I'm not a big fan either.  As it turns out my patch
crossed paths with Cris Maynard's patch.  He wrote a function extract the start
and end of the range to iterate without using the static vars.

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2423

I could also add his function into range.h if that is better.  The only down
side is that the function in 2423 behaves differently than the existing range
functions (doesn't handle comma separated lists).  So that might just cause
more confusion.

This perl programmer is all for first class functions.  But alas this is C....


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.