Wireshark-bugs: [Wireshark-bugs] [Bug 2433] add parsing of port ranges in ./wireshark/services
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 9 Apr 2008 19:01:10 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2433


Guy Harris <guy@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1652|review_for_checkin?         |review_for_checkin-
               Flag|                            |




--- Comment #4 from Guy Harris <guy@xxxxxxxxxxxx>  2008-04-09 19:01:04 GMT ---
(From update of attachment 1652)
It looks as if it doesn't just skip entries that are neither UDP, TCP, SCTP nor
DCCP.  You should probably add an else clause to the chain of ifs.

You also might want to add a MAX_DCCP_PORT #define to range.h (that's probably
not the right place, but it's where all the other MAX_*_PORT #defines are).

(It's too bad that cb_port_table and cb_service need to be static, but fixing
that requires fixing the range code API so that an additional argument is
passed to the callback; I may look at that at some point.  The older I get the
more I wish C had first-class functions....)


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.