Wireshark-bugs: [Wireshark-bugs] [Bug 2433] add parsing of port ranges in ./wireshark/services
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 9 Apr 2008 17:04:46 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2433


Andrew Feren <acferen@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1650|                            |review_for_checkin?
               Flag|                            |




--- Comment #1 from Andrew Feren <acferen@xxxxxxxxx>  2008-04-09 17:04:45 GMT ---
(From update of attachment 1650)
Note also adds check for "dccp" vs "dcp".  I think the "dcp" is a bug, but I
left it in for now.

Also Note.  I used MAX_UDP_PORT for dccp as I didn't see a MAX_DCCP_PORT in
range.h.

Maybe the right thing is to add MAX_DCCP_PORT, but this works for now.

Final comment.
This actually does more than was suggested in the original email.  In addition
to portA-portB ranges you can specify a comma separated list of ports.  Not
sure if this is good, bad, or neutral, but it was easier to just use the
existing range parsing functions than to write something just for this.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.