http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2407
Jim Young <jyoung@xxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1617| |review_for_checkin?
Flag| |
--- Comment #8 from Jim Young <jyoung@xxxxxxx> 2008-04-05 20:06:16 GMT ---
Created an attachment (id=1617)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1617)
Patch to ldap_reinit()
Attached is a patch to the ldap_reinit() function defined in
./asn1/ldap/packet-ldap-template.c (and ./epan/dissectors/packet-ldap.c) to fix
bug 2407. This particular bug was triggered by the order of steps used to walk
and free the nodes of the ldap_info_items list.
I'm not convinced this patch is the most elegant solution, but is does seem to
fix the bug and it does not appear to leave any extra orphaned memory (checked
with valgrind's memcheck).
Note: A more proper patch would ONLY patch ./asn1/ldap/packet-ldap-template.c
and would NOT directly patch ./epan/dissectors/packet-ldap.c. But a simple
unadorned "make" in the wireshark base directory does not trigger the necessary
magic to invoke ./tools/as2wrs.py within the ./asn1/ldap directory to produce
and then copy the packet-ldap.c and packet-ldap.h files into the
./epan/dissectors folder. (In my case I invoked an2wrs tool manually and then
copied the resulting packet-ldap.c and packet-ldap.h files into the
./epan/dissectors folder. A svn diff was created after I copied the files.
I edited the resulting diff file to remove the packet-ldap.h file changes
(since the packet-ldap.h patch only affected the comment of how to invoke
an2wrs).
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
