Wireshark-bugs: [Wireshark-bugs] [Bug 2384] SMPP+ which is customized by Huawei company can't be
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 25 Mar 2008 20:31:00 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2384





--- Comment #4 from Guy Harris <guy@xxxxxxxxxxxx>  2008-03-25 20:30:59 GMT ---
Some routines that return no value are being declared without a return type;
they should be declared as returning void, for example

static void
auth_acc_resp(proto_tree *tree, tvbuff_t *tvb)
{
    int          offset = 0;

    smpp_handle_int4(tree, tvb, hf_smpp_operation_result, &offset);
    smpp_handle_int1(tree, tvb, hf_smpp_notify_mode, &offset);

}

Also, most routines should be declared as static, as they're not called by
other dissectors.

Could you please attach the documentation for the Huawei extensions to this
bug?  If you could convert it to PDF form, that would be nice, as not everybody
has software that can read Word documents.  Also, is there a URL for that
documentation?


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.