http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2364
bboissin+wireshark@xxxxxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1555 is|0 |1
obsolete| |
Attachment #1557| |review_for_checkin?
Flag| |
--- Comment #3 from bboissin+wireshark@xxxxxxxxx 2008-03-16 10:00:25 GMT ---
Created an attachment (id=1557)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1557)
updated patch to add nd rdnss support (no memcpy into struct)
I updated the patch, sorry for doing the memcpy but that's was is done
everywhere in the file and since I'm not familiar with the codebase I took the
inspiration from the other cases in the file.
FYI other places that do the copying into struct thing in this file:
opt = &nd_opt_hdr;
tvb_memcpy(tvb, (guint8 *)opt, offset, sizeof *opt);
--
pi = &nd_opt_prefix_info;
tvb_memcpy(tvb, (guint8 *)pi, offset, sizeof *pi);
--
case ND_OPT_REDIRECTED_HEADER:
tvb_memcpy(tvb, (guint8 *)&nd_redirect_res, offset + 2, 6);
--
pi = &pibuf;
tvb_memcpy(tvb, (guint8 *)pi, offset, sizeof *pi);
--
map = &mapbuf;
tvb_memcpy(tvb, (guint8 *)map, offset, sizeof *map);
--
ri = &ribuf;
tvb_memcpy(tvb, (guint8 *)ri, offset, sizeof *ri);
--
opt_naack = &fmip6_opt_neighbor_advertisement_ack;
tvb_memcpy(tvb, (guint8 *)opt_naack, offset, sizeof *opt_naack);
--
opt = &fmip6_opt_hdr;
tvb_memcpy(tvb, (guint8 *)opt, offset, sizeof *opt);
--
opt_ip = &fmip6_opt_ip_address;
tvb_memcpy(tvb, (guint8 *)opt_ip, offset,
sizeof *opt_ip);
--
opt_nr = &fmip6_opt_new_router_prefix_info;
tvb_memcpy(tvb, (guint8 *)opt_nr, offset,
sizeof *opt_nr);
--
ni = &icmp6_nodeinfo;
tvb_memcpy(tvb, (guint8 *)ni, offset, sizeof *ni);
--
rr = &icmp6_router_renum;
tvb_memcpy(tvb, (guint8 *)rr, offset, sizeof *rr);
--
ra = &nd_router_advert;
tvb_memcpy(tvb, (guint8 *)ra, offset, sizeof *ra);
--
ns = &nd_neighbor_solicit;
tvb_memcpy(tvb, (guint8 *)ns, offset, sizeof *ns);
--
rd = &nd_redirect;
tvb_memcpy(tvb, (guint8 *)rd, offset, sizeof *rd);
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
