Wireshark-bugs: [Wireshark-bugs] [Bug 2347] X25 dissect checks payload and assumes IP before heu
Date: Fri, 14 Mar 2008 09:52:04 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2347


Gerhard Olsson <gerhard.nospam@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1532|review_for_checkin?         |
               Flag|                            |
Attachment #1532 is|0                           |1
           obsolete|                            |
   Attachment #1549|                            |review_for_checkin?
               Flag|                            |




--- Comment #5 from Gerhard Olsson <gerhard.nospam@xxxxxxxxx>  2008-03-14 09:51:54 GMT ---
Created an attachment (id=1549)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1549)
Adding preference instead of changing order

"Clean" version, not dependent of 2090. However, I must apply 2090 first, that
bug have effect before this one...

Some notes:
 * Set the default behavior to no. This changes the current behavior, but
should be reasonable. I find it easier to understand when always seeing the
data as "raw" information than having a occasional incorrect interpretation.
 * No indentation done for the controlling if statement (to simplify review)

More or less trivial patch.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.