Wireshark-bugs: [Wireshark-bugs] [Bug 2256] New: ansi_map does not execute is637 subdissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 11 Feb 2008 17:29:03 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2256

           Summary: ansi_map does not execute is637 subdissector
           Product: Wireshark
           Version: 0.99.7
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Trivial
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: martin.schimmer@xxxxxxxxx


Created an attachment (id=1457)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1457)
Contains packet-ansi_map.c code fix

Build Information:
wireshark 0.99.7 (SVN Rev 23910)

Copyright 1998-2007 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.1, with GLib 2.14.3, with WinPcap (version unknown),
with libz 1.2.3, with libpcre 6.4, with SMI 0.4.5, with ADNS, with Lua 5.1,
with

GnuTLS 1.6.1, with Gcrypt 1.2.3, with MIT Kerberos, with PortAudio PortAudio
V19-devel, with AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0.2
(packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, without
AirPcap.

Built using Microsoft Visual C++ 6.0 build 8804

--
Following is simple fix on wireshark 0.99.7 ansi_map dissector. This dissector
sometimes does not execute is637 subdissector when it could. This happens when
there's teleservice id  present in packet before bearer data. In this case,
original code fails because SMS_BearerData_tvb is NULL just before execution of
is637 dissector. My fix works the way that in such case, it stores
ansi_map_sms_tele_id into global static variable
is637_delayed_execution_tele_id and
dissector_try_port(is637_tele_id_dissector_table is then executed after the
bearer data is parsed in and SMS_BearerData_tvb is initialized.

I'm sorry that I'm not familiar with formal process of fixing the code and
submiting changes, so I hope that author/maintainer of ansi_map could implement
this simple fix, as supplied in attachment.

Note that I tested it on my .cap file and the fix works, but unfortunately I
cannot disclose the .cap file.

Cheers!
Martin
martin.schimmer@xxxxxxxxx


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.