Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1833] Dissector for srvloc protocol (SLP) does not display attribute-list corr

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1833





--- Comment #10 from Jaap Keuter <jaap.keuter@xxxxxxxxx>  2008-01-25 06:28:15 GMT ---
It is usually Good Practice(sm) to separate out large whitespace changes from
function changes in a patch, and send two patches. I've done that and only
submitted the functional change patch, since the whitespace patch messed up my
source formatting at least.
What also struck me was that the logic in ATTRRPLY was changed. It is good to
keep track of offset, but it also allowed the while loop to run even though
length==0. I've did not commit that change, pending review.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.