Wireshark-bugs: [Wireshark-bugs] [Bug 1443] Enhancements to configuration of sub-dissectors usin
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1443
Stig Bjørlykke <stig@xxxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stig@xxxxxxxxxxxxx
--- Comment #4 from Stig Bjørlykke <stig@xxxxxxxxxxxxx> 2008-01-21 21:19:35 GMT ---
Hi Doug!
I found this patch today, and I really like it!
After looking at it for a few hours I have some comments:
1. wsclist.c forces GTK 1, is this safe? I really think we should implement
this features for GTK 2, or reuse some functionality we already have?
2. I'm unable to edit a filter specified decode. I can change the Sub-Protocol
but not the filter itself.
3. The filter specified decodes only list some chosen parent protocols. Is it
possible to make this more generic and add all protocols here?
4. I'm able to put "equal" entries in the "Decode As" list. They are not equal
because they are "sub dissectors" within a protocol, but the list only show the
protocol name. This can be confusing, and it's impossible to know which one to
use.
5. The newly added protocol in the "Decode As" list should be selected after
adding it, so the user will easily find it.
6. Maybe we should resolve the OIDs in the "Parent Key" list?
7. And add help buttons on the new windows.
And I know this patch is one year old, but it was not too much work to get it
to compile. I can upload a new patch if anyone else wants to try it. I'm
willing to work some more on this, unless you have some time? :) Or maybe you
have improved it since adding this patch?
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
