Wireshark-bugs: [Wireshark-bugs] [Bug 1930] Patch to rtp_player.c for a smaller default max heig
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1930
------- Comment #4 from jyoung@xxxxxxx 2008-01-10 19:11 GMT -------
Hello Richard,
I do think my second proposed patch is useful and ultimately the better way to
go than my first patch.
Please note that IF there are more than the configured graphs, the other graphs
are accessable, but one has to scroll up or down to see them.
With the current hard coded default of 5 graphs the RTP Players window is so
tall that the RTP Player buttons are inaccesable to a user on a 1024x768
screen.
My first patch simply reduced the default number of visable VoIP graphs from
five to four. With the first patch in place a user with a resolution of
1024x768 was then able to access the RTP Player buttons.
But then a few of my co-workers suggested to make the number of visable graphs
configurable. Some of them have much larger screens, they wanted to see see
MORE than the current five graphs. One co-worker (poor soul) is still using a
a laptop with an even smaller screen (800x600)!
Making this a variable, as opposed to a hard limit also has the nice effect
when I want to work with just one graph at a time. I no longer have to waste
all the desktop space with a tall RTP Player window. So I choose the limits as
a minimum of 1 and an (somewhat arbitrary but pratical) maximum of 10.
The problem that I was attempting to fix is that the RTP Player window buttons
are inaccessaable to a user on a system with 1024x768 display if the trace has
five or more VoIP graphs.
It seemed more useful to make the number of visable graphs a configrable
solution then simply imposing a hard limitation of four displayed graphs. ;-)
I'll see if I can cook up an example trace.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
