Wireshark-bugs: [Wireshark-bugs] [Bug 2017] VoIP trace crashes Wireshark when specific RTP Playe
Date: Mon, 17 Dec 2007 19:05:16 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2017





------- Comment #11 from jeff.morriss@xxxxxxxxxxx  2007-12-17 19:05 GMT -------
(In reply to comment #10)
> I wrote a program that did 100,000 mallocs on Linux and never got a duplicate
> like we're getting in Wireshark with the COPY_ADDRESS macro.  I noticed that
> most, if not all, the other GTK code using the COPY_ADDRESS macro never bothers
> to free the memory it allocated!  Perhaps that's why only voip_calls.c exhibits
> the problem when freeing ;)

I cleaned up a bunch of those memory leaks a while ago (revs 22568, 22571,
22573) but only in epan/dissectors/.  I started looking at memory leaks in the
taps and got sufficiently lost/disheartened that I gave up.  IIRC my feeling at
the time was that there should be almost no calls to COPY_ADDRESS; instead
SE_COPY_ADDRESS should be used 99% of the time (though there were a couple
places where COPY_ADDRESS had a significant benefit--packet reassembly was one
place I think).


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.