Wireshark-bugs: [Wireshark-bugs] [Bug 2103] TCP dissector fail to handle heuristic dissectors fo
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2103
------- Comment #7 from gerhard.nospam@xxxxxxxxx 2007-12-14 23:08 GMT -------
Thanks for the comments.
I am certainly no expert in Wireshark.
Without defending the solution, is not using conversation something that should
be generally to heuristic dissectors to avoid loops?
Reference implementations are good, but someone must do them...
Question: Even if returning the number of bytes is the solution, is there a
problem?
Note: Heuristic dissectors should return no of used bytes so a separate call to
find no of bytes used should be called. If you can get it from the
tcp_dissect_pdu, a separate call to find size is eliminated.
(In reply to comment #5)
> But I'm not sure about:
> return length_remaining - fixed_len;
> and the heuristic stuff because either there's not enough data for the
> heuristic and it must reject the packet or it has already found it's a COT
> stream and then the heuristic function shouldn't be called anymore.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
