Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2103] TCP dissector fail to handle heuristic dissectors for mult segments (XOT

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2103


gerhard.nospam@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1271|                            |review_for_checkin?
               Flag|                            |




------- Comment #1 from gerhard.nospam@xxxxxxxxx  2007-12-14 13:09 GMT -------
Created an attachment (id=1271)
 --> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1271&action=view)
Adapt tcp_dissect_pdu for heuristic dissectors

This changes updates tcp_dissect_pdu to return the number of bytes needed (<0)
or used (>0) (or ==0 when error. This should not be a problem with
non-heuristic dissectors.
It also sets DESEGMENT_ONE_MORE_SEGMENT when the header is not recieved (as we
really do not know how many bytes to request).
-       pinfo->desegment_len = fixed_len - length_remaining;
-       return;
+       pinfo->desegment_len = DESEGMENT_ONE_MORE_SEGMENT;
+       return length_remaining - fixed_len;

Additionally, there is a small cleanup in packet-xot.c to better conform with
the standards as I interpret them from README.developers


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.