Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 2092] New: small typos in the example code in doc/README.developer

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2092

           Summary: small typos in the example code in doc/README.developer
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Documentation
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: nm127@xxxxxxxxxxx


Build Information:
$ svn info
Path: .
URL: http://anonsvn.wireshark.org/wireshark/trunk
Repository Root: http://anonsvn.wireshark.org/wireshark
Repository UUID: f5534014-38df-0310-8fa8-9805f1628bb7
Revision: 23839
Node Kind: directory
Schedule: normal
Last Changed Author: kukosa
Last Changed Rev: 23839
Last Changed Date: 2007-12-11 12:54:15 +0100 (k, 11 dec 2007)

--
The function prefs_register_bool_preference() is a wrapper fo
register_preference(). The second parameter is the name which is checked in
wireshark/epan/prefs.c . The following comment is before the check code:

        /*
         * Make sure that only lower-case ASCII letters, numbers,
         * underscores, and dots appear in the preference name.
         *
         * Crash if there is, as that's an error in the code;
         * you can make the title and description nice strings
         * with capitalization, white space, punctuation, etc.,
         * but the name can be used on the command line,
         * and shouldn't require quoting, shifting, etc.
         */

This means that the "showHex" name cannot be the name paramter. Changing it to
"show_hex" should be fine.

There is also a missing ';' at the end of a line in the example. See the
attached patch.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.