Wireshark-bugs: [Wireshark-bugs] [Bug 1970] review_for_checkin : plugins IPMB protocol with GPL
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 29 Nov 2007 12:21:58 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1970





------- Comment #6 from jaap.keuter@xxxxxxxxx  2007-11-29 12:21 GMT -------
A couple of remarks on the patches.
1. Add the $Id$ tag to header of the files, for automatic SVN tagging.
2. Remove all remaining C++ style comments. 
3. The \ is not applicable as constant string continuation character, they need
to be removed.
4. In Makefile.common, the symbol DISSECTOR_SRC may only contain packet-ipmb.c.
The rest must be moved to DISSECTOR_SUPPORT_SRC.
5. The readme.txt has internal relevance only, it should be removed from the
patch.
6. Makefile.in should no be in the patch.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.