Wireshark-bugs: [Wireshark-bugs] [Bug 1804] packet-fcsb3.c display filter field problems
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1804
christopher.maynard@xxxxxxxxx changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #1175| |review_for_checkin?
Flag| |
------- Comment #2 from christopher.maynard@xxxxxxxxx 2007-11-29 05:07 GMT -------
Created an attachment (id=1175)
--> (http://bugs.wireshark.org/bugzilla/attachment.cgi?id=1175&action=view)
Patch
As I said in my first comment, I know nothing of this protocol so I think
someone else should make the decision as to how it should be corrected.
However, since nobody else has made a decision, I am submitting a patch that
changes the PROTOABBREV from "sb3" to "fcsb3". I also changed all display
filter field prefixes to match, which means they go from "sbccs" to "fcsb3".
I still don't know if this is the best name to use though. For example, I
think "sbccs" stands for "Single Byte Command Common Services", so perhaps the
better, more accurate full name should be, "Fibre Channel Single Byte Command
Common Services", with a PROTOABBREV of "fcsbccs" and maybe even a file name
change to match as well.
Anyway, my choice here introduces the least amount of changes to the dissector,
but at least the display filter field names will be consistent and match the
PROTOABBREV now. If you have a better alternative, feel free to submit your
own patch. Lastly, you'll notice that I did not change all the hf_sbccs_*'s to
hf_fcsb3_*'s, but maybe they should be changed too along with the various
function names???
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
