Wireshark-bugs: [Wireshark-bugs] [Bug 1999] Patch: Wifi Protected Setup Dissector Support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 22 Nov 2007 00:25:28 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1999





------- Comment #4 from stig@xxxxxxxxxxxxx  2007-11-22 00:25 GMT -------
(From update of attachment 1133)
Some initial comments:
- When looping on a length from the package, also check the total length of the
package.
- Add a description field (blurb) to the hf_ entries
- Don't use C++ comments in C code
- Terminate all value_string tables with {0, NULL}
- Maybe include the hex bytes from Type, Length and Value in the outermost TLV
entry?  So when you select the tree node in the packet details, both type,
length and value are highlighted in the packet bytes.
- Maybe dump the "Value" as something more useful?
- Maybe shorten "wps.type.*" to only "wps.*", and use "wps.type" for data type
and "wps.length" for data length?
- Remove debug code (#if 0)
- Update to latest SVN, as some defines has moved to epan/eap.h


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.