http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1974
------- Comment #6 from cwen01390@xxxxxxxxxxxxx 2007-11-07 01:28 GMT -------
I thougnt about the head file way but I tried to avoid modifing another
dissector. I think it is right that use head file to keep the updates being
available to wimaxasncp. Thanks for your suggestion.
So, shall I create a new attachment to upload the new patch or create a new bug
to do that?
(In reply to comment #5)
> I've tested it with available captures here. I don't know EAP at all, but I'm
> told that it looks OK, although we've seen requests with string EAP-TLS
> reassembled from fragments all over the test file.
> The issue with the indentation wasn't the width of the tabs, it was that the
> existing file uses space characters instead.
> Looking at the way sminmpec is included:
> - packet-wimaxasncp.c includes <epan/sminmpec.h>
> - epan/sminmpec.h includes #defines for the symbols and this line:
> WS_VAR_IMPORT const value_string sminmpec_values[];
> - the file epan/libwireshark.def also includes the line:
> sminmpec_values DATA
> So something similar should be done for the copy/pasted parts taken from
> packet-eap.c so that wimaxasncp catches any updates/improvements.
--
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
