Wireshark-bugs: [Wireshark-bugs] [Bug 1430] EtherCAT dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 20 Sep 2007 19:45:12 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1430





------- Comment #19 from jaap.keuter@xxxxxxxxx  2007-09-20 19:45 GMT -------
A quick look at the code reveiled some problems:
1. Don't include <gmodule.h> nor "moduleinfo.h", you don't need to
2. Don't use anonymous unions, some compilers can't handle them
3. Add ethertypes to epan/etypes.h and epan/dissectors/packet-ethertype.c
4. Don't register a module without attaching preferences
5. Depending on pragmas isn't portable.
6. ams.h is listed in makefile.common doesn't exist.

The rest I leave to Anders ;)


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.