Wireshark-bugs: [Wireshark-bugs] [Bug 1792] New: ISIS dissector does not decode Restart Signalin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Fri, 24 Aug 2007 17:43:34 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1792

           Summary: ISIS dissector does not decode Restart Signaling CLVs
                    correctly
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: todd.martin@xxxxxxx


Build Information:
Version 0.99.7-tjm-trunk-1 (SVN Rev 22533)

Compiled with GTK+ 2.10.12, with GLib 2.12.12, with WinPcap (version unknown),
with libz 1.2.3, with libpcre 6.4, with Net-SNMP 5.4, with ADNS, with Lua 5.1,
with GnuTLS 1.6.1, with Gcrypt 1.2.3, with MIT Kerberos, with PortAudio
PortAudio V19-devel, with AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 3.1
(packet.dll version 3, 1, 0, 27), based on libpcap version 0.9[.x], without
AirPcap.

Built using Microsoft Visual C++ 8.0 build 50727
--
The ISIS dissector does not decode all Restart Signaling CLVs correctly.  The
dissector assumes that the length of the Restart Signaling CLV will always be 3
and that the TLV is malformed if this is not the case.  This is incorrect.  The
CLV could have other lengths because the presence of some bytes is dependent on
the values of certain flags.

This patch adds the following enhancements:
- Decodes all valid Restart Signaling CLVs
- The restart flags are now shown in a tree and have display filters for them
- The Remaining hold time field now has a display filter
- The Restarting Neighbor Id field is now decoded
- Corrected another CLV decoder that assumed the length of a system ID was 6
and hard coded that value instead of using the id_length variable.

A capture file showing ISIS PDUs using the graceful restart signaling CLVs is
attached.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.