Wireshark-bugs: [Wireshark-bugs] [Bug 1606] Improve preferences for Netflow
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 21 Aug 2007 20:43:11 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1606





------- Comment #4 from richardv@xxxxxxxxxxxxx  2007-08-21 20:43 GMT -------
Hrm. I don't find the memory management of this particularly easy to follow,
I'm afraid.

Why does proto_register_netflow() need to copy the global_*_ports ranges?
afaict they are always freed before they are used.

Would it be possible to:
 * add a comment next to the declarations of netflow_ports and ipfix_ports
stating what they do
 * extract the common parts of proto_reg_handoff_netflow and netflow_reinit to
a common function?


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.