Wireshark-bugs: [Wireshark-bugs] [Bug 1673] New: pana header parsing : Session Id field left
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 5 Jul 2007 11:43:38 +0000 (GMT)
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1673

           Summary: pana header parsing : Session Id field left
           Product: Wireshark
           Version: 0.99.5
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Trivial
          Priority: Medium
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: romain.raynaud@xxxxxxxxx
                CC: romain.raynaud@xxxxxxxxx


Build Information:
Version 0.99.5 (SVN Rev 20677)

Copyright 1998-2007 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.10.7, with GLib 2.12.7, with WinPcap (version unknown),
with libz 1.2.3, with libpcre 6.4, with Net-SNMP 5.4, with ADNS, with Lua 5.1,
with GnuTLS 1.6.1, with Gcrypt 1.2.3, with MIT Kerberos, with PortAudio
PortAudio V19-devel, with AirPcap.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0
(packet.dll version 4.0.0.755), based on libpcap version 0.9.5, without
AirPcap.

Built using Microsoft Visual C++ 6.0 build 8804

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
Hello

When Wireshak parse the pana protocol Header, he left the session_Id fiel.
In the pana draft 17 from IETF  it's not writen that this field is optionnal.
Your pana.cap example don't care about this field too. but when you start the
pana client and the pana server found on opendiameter website the wireshark
parser don't work. wireshark tell "[malformed packet]" because of the
session_Id field.

I think it just needed to add in the
wireshark-0.99.5\epan\dissectors\packet-pana.c file
////////////////////////////////////////////////////////////////////////
/* Initialize the protocol and registered fields */
...
static int hf_pana_msg_type = -1;
++static int hf_pana_sessionid = -1;
static int hf_pana_seqnumber = -1;
...

/*
 * Function for the PANA PDU dissector.
 */
static void
dissect_pana_pdu(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree)
{
...
       gint16 avp_length;
++       guint32 session_id;
       guint32 seq_num;
...
       msg_type = tvb_get_ntohs(tvb, 6);
++       session_id = tvb_get_ntohl(tvb, 8);
~~       seq_num = tvb_get_ntohl(tvb, 12);
~~       avp_length = msg_length-16;
...
++       proto_tree_add_item(pana_tree, hf_pana_sessionid, tvb, offset, 4,
FALSE);
++       offset += 4;

       proto_tree_add_item(pana_tree, hf_pana_seqnumber, tvb, offset, 4,
FALSE);
       offset += 4;
...
}
////////////////////////////////////////////////////////////////////


thanks


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.