Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1584] WEP decryption fails when WEP Key specified with colon separation

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1584





------- Comment #2 from stephentfisher@xxxxxxxxx  2007-05-29 02:48 GMT -------
Thanks for your bug report.  I've only had a limited time to work on the issue,
so below are my notes to myself or another developer to pick up on when they
get a chance to review this bug again:

The problematic code is below (starting in file
epan/dissectors/packet-ieee80211.c at line 10242):

  for(i = 0; i < MAX_ENCRYPTION_KEYS; i++)
  {
    tmpk = g_strdup(wep_keystr[i]);

    dk = parse_key_string(tmpk);

    if(dk != NULL)
    {

This code does not take into account that the colons may be present.  Changing
it to the code below fixes the problem in this bug, *but* breaks the format of
wep:1234567890 so it can't be used:

   for(i = 0; i < MAX_ENCRYPTION_KEYS; i++)
   {
-    tmpk = g_strdup(wep_keystr[i]);
+    bytes = g_byte_array_new();
+    hex_str_to_bytes(wep_keystr[i], bytes, FALSE);
+    tmpk = g_strdup(bytes_to_str(bytes->data, bytes->len));

The above code or similar probably needs to be worked into the
parse_key_string() function in epan/crypt/airpdcap.c


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.