Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 1601] New: pppdump wiretap fails on 0-length packets

[bugzilla-daemon@xxxxxxxxxxxxx]

http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1601

           Summary: pppdump wiretap fails on 0-length packets
           Product: Wireshark
           Version: SVN
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: b-wireshark@xxxxxxxxxxxxxxx


Build Information:
wireshark 0.99.4

Copyright 1998-2006 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.10.11, with GLib 2.12.11, with libpcap 0.9.5, with libz
1.2.3, with libpcre 6.7, without UCD-SNMP or Net-SNMP, with ADNS, without Lua,
with GnuTLS 1.4.4, with Gcrypt 1.2.3, with MIT Kerberos, with PortAudio <= V18,
without AirPcap.

Running on Linux 2.6.20-15-386, with libpcap version 0.9.5.

Built using gcc 4.1.2 (Ubuntu 4.1.2-0ubuntu4).

--
A pppdump file with a zero length packet triggers this assertion:
22:43:34          Err  file pppdump.c: line 618 (collate): assertion failed:
(num_bytes_to_skip < n)

The attached patch fixes this, by simply skipping over zero-length pppdump
records. Maybe there's a better solution, but this at least stops the crash.


-- 
Configure bugmail: http://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.